Reliably disable ANSI escaping in command output when output is redirected; add support for NO_COLOR; fix inconsistencies - #480
Conversation
…ected; add support for `NO_COLOR`; fixes inconsistencies. Assisted-by: Claude:claude-fable-5
| // Serilog's console sink applies the `NO_COLOR` convention itself, unconditionally, overriding whatever | ||
| // theme it's passed. When `--force-color` has opted back out of `NO_COLOR`, the variable is cleared (for | ||
| // this process only) so that the sink can't undo the decision made here. | ||
| if (!NoColor && noColorSetInEnvironment) |
There was a problem hiding this comment.
Is this worth the quirky workaround?
There was a problem hiding this comment.
When we migrate away from using ConsoleTheme this will (thankfully) go away; until then it does at least mean that --force-color works consisently for all commands.
There was a problem hiding this comment.
What would it take to move away from ConsoleTheme?
There was a problem hiding this comment.
Probably not a huge effort, mostly digging into why we haven't been able to do it previously :-)
There was a problem hiding this comment.
I'll give it a shot tomorrow; want me to fold it in here, or send a follow-up?
There was a problem hiding this comment.
Maybe we can do it as a follow-up, because this is still 90% of what we want either way?
3 participants
Consolidation of output formatting into a single
OutputFormattype has been an ongoing process. I started chasing an ANSI escaping bug (ANSI escape sequences appearing in redirected output) and decided to try consolidating more in the process, which came out reasonably nicely.seqcli printnow relies onOutputFormatinstead of duplicated formatting logic. Handling of colour-related flags, settings, and environment variables is now centralized into theOutputFormatconstructor.Getting rid of
Serilog.Expressions/Serilog console theming in favour ofSeq.Syntaxand expression templates would be a worthwhile follow-up.